Prevent payment method deletion in local environment when using Stripe production account #9566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n prod or local env. on production or local stripe account
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
dmvrtx
approved these changes
Oct 16, 2024
zmaglica
deleted the
fix/5384-prevent-pm-detach-on-prod-when-user-is-deleted-on-localhost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5384
Changes proposed in this Pull Request
This PR introduces a safeguard for scenarios where, for example, you clone a production environment or a live version of a WordPress site to your local environment for testing. In such cases, there is a potential risk of deleting a customer or payment method locally, which could trigger the detachment of the payment method from the live Stripe account.
To prevent this, this PR adds a check that ensures the payment method will not be detached if:
This means that if you delete a customer or payment method locally from the admin page using a live Stripe account, this safeguard will prevent it from affecting the live environment.
This update is particularly useful for developers testing live versions of their websites locally, helping them avoid unintended issues with attached payment methods.
Testing instructions
Follow the reproduction steps outlined in the linked issue, but in the final step, ensure the payment method is not detached. This PR introduces checks across various environments and test settings, so feel free to explore different configurations. For example, you can hardcode the
WC_Payments::mode()->is_live()function to return specific values for testing. Additionally, you can modify theWP_ENVIRONMENT_TYPEconstant to simulate different environments as needed.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge